Conversation
…iguration logic - Introduced a new optional boolean field `NetworkHelper` in `LinodeMachineSpec` to indicate if the network helper should be used, defaulting to true. - Updated the instance configuration logic in `linodemachine_controller.go` to conditionally enable the network helper based on the new field.
- Updated the comment for the `NetworkHelper` field in `LinodeMachineSpec` to provide clearer guidance on its purpose and usage. - Added a link to the relevant documentation for automatic networking configuration.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #806 +/- ##
==========================================
- Coverage 63.16% 63.16% -0.01%
==========================================
Files 71 71
Lines 7292 7305 +13
==========================================
+ Hits 4606 4614 +8
- Misses 2415 2419 +4
- Partials 271 272 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eljohnson92
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetworkHelperinLinodeMachineSpecto indicate if the network helper should be used, defaulting to true.linodemachine_controller.goto enable the network helper based on the new field.Note: Disabled for flatcar based flavor (set to false)
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: